update project

CONTRIBUTING.md

+# Contributing
+
+If you have any issues or ideas for improvement you can send me an email to _thl-cmk[at]outlook[dot]com_.
+
+For some fixes/improvements I migth need a _snmpwalk_ fom the device in question.
+This must contain
+
+- .1.3.6.1.2.1.1.1 sysDescr 
+- .1.3.6.1.2.1.1.2 sysObjectID
+
+and all the SNMP OIDs used in the plugin.
+
+If you run the _snmpwalk_ command, please uses these options _**-ObentU**_ in addition to your snmp options like community, version etc.
+For example:
+```
+snmpwalk -v2c -c public -ObentU 10.10.10.10 .1.3.6.1.2.1.1.1 > hostname.snmpwalk
+snmpwalk -v2c -c public -ObentU 10.10.10.10 .1.3.6.1.2.1.1.2 >> hostname.snmpwalk
+snmpwalk -v2c -c public -ObentU 10.10.10.10 .1.0.8802.1.1.2.1.4.1.1 >> hostname.snmpwalk
+snmpwalk -v2c -c public -ObentU 10.10.10.10 .1.3.6.1.2.1.31.1.1.1.1 >> hostname.snmpwalk
+```

README.md

@@ -11,6 +11,10 @@ Adds the LLDP information from network devices to the inventory
     *  you can remove the domain name from the neighbour device name
     *  you can replace interface names with short names
 
+---
+#### Want to contribute?
+Nice ;-) Have a look at the [contribution guidelines](CONTRIBUTING.md "Contributing")
+---
 
 Sample output
 

agent_based/inv_lldp_cache.py

@@ -20,6 +20,7 @@
 # 2021-03-22: workaround for oid_end != x.ifIndex.y  (for Cisco UCS FIs / lbarbier[at]arkane-studios[dot]com)
 # 2021-03-22: added handling of lldpchassisidsubtype 5 -> network address ipv4/ipv6
 # 2021-07-10: made use short interface names configurable via wato
+# 2021-07-19: fix for default parameters
 
 import re
 from typing import List
@@ -214,10 +215,10 @@ def parse_inv_lldp_cache(string_table: List[StringTable]) -> list:
 
 
 def inventory_lldp_cache(params, section: list) -> InventoryResult:
-    removecolumns = params['removecolumns']
-    remove_domain = params['remove_domain']
-    domain_name = params['domain_name']
-    use_short_if_name = params['use_short_if_name']
+    removecolumns = params.get('removecolumns', [])
+    remove_domain = params.get('remove_domain', False)
+    domain_name = params.get('domain_name', '')
+    use_short_if_name = params.get('use_short_if_name', False)
 
     path= ['networking', 'lldp_cache']
     
@@ -295,10 +296,6 @@ register.inventory_plugin(
     name='inv_lldp_cache',
     inventory_function=inventory_lldp_cache,
     inventory_default_parameters={
-        'removecolumns': [],
-        'remove_domain': False,
-        'domain_name': '',
-        'use_short_if_name': False,
     },
     inventory_ruleset_name='inv_lldp_cache',
 )

packages/inv_lldp_cache

@@ -16,7 +16,7 @@
  'name': 'inv_lldp_cache',
  'num_files': 3,
  'title': 'inventory for LLDP cache',
- 'version': '20210710.v05b',
+ 'version': '20210719.v05c',
  'version.min_required': '2.0.0',
- 'version.packaged': '2021.04.10',
+ 'version.packaged': '2021.07.14',
  'version.usable_until': None}
\ No newline at end of file