diff --git a/active_check_traceroute.mkp b/active_check_traceroute.mkp index b529d23158a1450ab85238ee9c0deb7fc99c6553..292b966e9f25b975734c3405f1aa387f73b7fbb6 100644 Binary files a/active_check_traceroute.mkp and b/active_check_traceroute.mkp differ diff --git a/lib/nagios/plugins/check_traceroute b/lib/nagios/plugins/check_traceroute index 9fa0447b211070433124c2b05b87f6ae682221ed..a483066de256ee4ac5446f70778d87daea82345c 100755 --- a/lib/nagios/plugins/check_traceroute +++ b/lib/nagios/plugins/check_traceroute @@ -123,7 +123,8 @@ def _execute_traceroute(target, nodns, method, address_family, queries, max_ttl, if (source_int is not None) or (source_addr is not None): cmd = ' '.join(cmd) - shell = True + # uncomment this line to make source interface and source address option work + # shell = True p = subprocess.Popen(args=cmd, stdout=subprocess.PIPE, stderr=subprocess.PIPE, encoding='utf8', shell=shell) sto, ste = p.communicate() diff --git a/packages/active_check_traceroute b/packages/active_check_traceroute index d05b8224367b986a45c34839e6dd0ffc49b95923..963bc243b44a64953edf61c845ffc15dedaac4fc 100644 --- a/packages/active_check_traceroute +++ b/packages/active_check_traceroute @@ -13,8 +13,10 @@ '\n' 'Source address and source interface uses the "shell=True" ' 'option in in\n' - 'the "subprocess.Popen" command. This is highly insecure, so ' - 'be careful.\n' + 'the "subprocess.Popen" command. This is insecure, so be ' + 'careful.\n' + 'To actvate this options you need to uncomment the line "# ' + 'shell=True" in ~/lib/nagios/plugins/check_traceroute.\n' '\n' 'Note: the original option TCP path trace also needs root ' 'permissions.\n' @@ -31,8 +33,8 @@ 'plugins/metrics/traceroute.py']}, 'name': 'active_check_traceroute', 'num_files': 4, - 'title': 'Active Check Traceroute', - 'version': '20212104.v.0.0.1a', + 'title': 'Check Traceroute (extended)', + 'version': '20212107.v.0.0.1b', 'version.min_required': '2.0.0', 'version.packaged': '2021.09.20', 'version.usable_until': None} \ No newline at end of file