diff --git a/agent_based/checkpoint_vsx_system.py b/agent_based/checkpoint_vsx_system.py index e60509b4bcba5143250ebffa12baece5f5654f55..171320a1b98e3efe823ee4354059e908a9592e75 100644 --- a/agent_based/checkpoint_vsx_system.py +++ b/agent_based/checkpoint_vsx_system.py @@ -137,6 +137,7 @@ def parse_checkpoint_vsx_system(string_table: StringTable) -> Optional[Dict[str, vsxCountersBytesDroppedTotal, vsxCountersBytesRejectedTotal, vsxCountersLoggedTotal = entry except ValueError: return + vsx_systems[vsxStatusVsName] = CheckpointVsx( vsxStatusVSId=vsxStatusVSId, vsxStatusVsType=vsxStatusVsType, @@ -185,7 +186,8 @@ def check_checkpoint_vsx_system(item, params, section: Dict[str, CheckpointVsx]) if vsx.vsxStatusVsType.lower() in ['virtual system', 'vsx gateway']: yield Result(state=State.OK, notice=f'System name: {item}') yield Result(state=State.OK, summary=f'Main IP: {vsx.vsxStatusMainIP}') - yield Result(state=State.OK, summary=f'VS ID: {vsx.vsxStatusVSId}', details='Virtual system ID:') + yield Result(state=State.OK, summary=f'VS ID: {vsx.vsxStatusVSId}', + details=f'Virtual system ID: {vsx.vsxStatusVSId}') yield Result(state=State.OK, notice=f'System type: {vsx.vsxStatusVsType}') if not vsx.vsxStatusHAState.lower() in ['active', 'standby']: @@ -294,7 +296,7 @@ register.check_plugin( service_name='VSX System %s', discovery_function=discovery_checkpoint_vsx_system, discovery_default_parameters={ - 'vs_type': ['virtual system', 'vsx gateway'] + 'vs_type': ['virtual system'] }, discovery_ruleset_name='discovery_checkpoint_vsx_system', check_function=check_checkpoint_vsx_system, diff --git a/checkpoint_vsx_system.mkp b/checkpoint_vsx_system.mkp index 7ba13e66108c46971d51de73b77d46b78da104dc..e60d912aa55f449c14a436a7318aae75142ed593 100644 Binary files a/checkpoint_vsx_system.mkp and b/checkpoint_vsx_system.mkp differ diff --git a/packages/checkpoint_vsx_system b/packages/checkpoint_vsx_system index 3558a34d7f4bb2cc5435dd0e98ec5ec5fb2aaad5..ebf407ff5ed4e4e59990542e7b90840dbdfba495 100644 --- a/packages/checkpoint_vsx_system +++ b/packages/checkpoint_vsx_system @@ -15,7 +15,7 @@ 'name': 'checkpoint_vsx_system', 'num_files': 3, 'title': 'Check Point VSX system status and counter', - 'version': '20210907.v.0.3a', + 'version': '20210921.v.0.3a', 'version.min_required': '2.0.0', - 'version.packaged': '2021.07.14', + 'version.packaged': '2021.09.20', 'version.usable_until': None} \ No newline at end of file diff --git a/web/plugins/metrics/checkpoint_vsx_system.py b/web/plugins/metrics/checkpoint_vsx_system.py index 1cc2923b373af13ebce91a6b6abc86130d739c29..37560585392e82ecffba9be9f68c7aa0dd626343 100644 --- a/web/plugins/metrics/checkpoint_vsx_system.py +++ b/web/plugins/metrics/checkpoint_vsx_system.py @@ -96,9 +96,9 @@ graph_info['checkpoint_vsx_connections'] = { graph_info['checkpoint_vsx_packets'] = { 'title': _('Check Point VSX: Packets'), 'metrics': [ - ('checkpoint_vsx_packets_rejected', 'line'), - ('checkpoint_vsx_packets_dropped', 'line'), - ('checkpoint_vsx_packets_accepted', 'line'), + ('checkpoint_vsx_packets_rejected', 'stack'), + ('checkpoint_vsx_packets_dropped', 'stack'), + ('checkpoint_vsx_packets_accepted', 'stack'), ('checkpoint_vsx_packets_processed', 'line'), ] } @@ -112,10 +112,10 @@ graph_info['checkpoint_vsx_bytes'] = { ] } -graph_info['checkpoint_vsx_logges_send'] = { +graph_info['checkpoint_vsx_loggs_send'] = { 'title': _('Check Point VSX: Logs'), 'metrics': [ - ('checkpoint_vsx_loggs_send', 'line'), + ('checkpoint_vsx_loggs_send', 'area'), ] } diff --git a/web/plugins/wato/checkpoint_vsx_system.py b/web/plugins/wato/checkpoint_vsx_system.py index b3625b8dd18a91803465c7faeaef3c7046203022..aabe424909e35ddcfd295d4c594f573d80c98cea 100644 --- a/web/plugins/wato/checkpoint_vsx_system.py +++ b/web/plugins/wato/checkpoint_vsx_system.py @@ -96,10 +96,10 @@ rulespec_registry.register( def _valuespec_discovery_checkpoint_vsx_system(): _vs_types = [ - ('virtual system', 'Virtual system'), - ('vsx gateway', 'VSX gateway'), - ('virtual switch', 'Virtual switch'), - ('virtual router', 'Virtual router'), + ('virtual system', 'Virtual System'), + ('vsx gateway', 'VSX Gateway'), + ('virtual switch', 'Virtual Switch'), + ('virtual router', 'Virtual Router'), ] return Transform( Dictionary( @@ -108,11 +108,11 @@ def _valuespec_discovery_checkpoint_vsx_system(): ('vs_type', ListChoice( title=_('VS types to discover'), - help=_('Virtual system types to discover'), + help=_('Virtual system types to discover. Note: if you select "VSX Gateway", ' + 'this will also discover ClusterXL systems.'), choices=_vs_types, default_value=[ 'virtual system', - 'vsx gateway', ], )), ],