diff --git a/agent_based/checkpoint_fw_connections.py b/agent_based/checkpoint_fw_connections.py index 49622bd57eb13a3b5b7fcb82bf2e55ad85a78486..4f07e0ad50af0371f362de6fab3f4b04e33873f0 100644 --- a/agent_based/checkpoint_fw_connections.py +++ b/agent_based/checkpoint_fw_connections.py @@ -31,7 +31,7 @@ import time from dataclasses import dataclass -from typing import List, Dict, Any, Optional +from typing import List, Optional from cmk.base.plugins.agent_based.agent_based_api.v1 import ( register, @@ -48,7 +48,6 @@ from cmk.base.plugins.agent_based.agent_based_api.v1 import ( get_rate, GetRateError, get_value_store, - IgnoreResultsError, render, ) from cmk.base.plugins.agent_based.agent_based_api.v1.type_defs import ( @@ -172,6 +171,7 @@ def check_checkpoint_fw_connections(params, section: CheckpointFwConnections) -> register.snmp_section( name='checkpoint_fw_connections', parse_function=parse_checkpoint_fw_connections, + supersedes=['checkpoint_connections'], fetch=[ SNMPTree( base='.1.3.6.1.4.1.2620.1.1.26.11', # CHECKPOINT-MIB::fwConnectionsStat @@ -193,12 +193,15 @@ register.snmp_section( ] ), ], - detect=any_of( - startswith('.1.3.6.1.2.1.1.2.0', '.1.3.6.1.4.1.2620'), - all_of( - equals('.1.3.6.1.2.1.1.2.0', '.1.3.6.1.4.1.8072.3.2.10'), - equals('.1.3.6.1.4.1.2620.1.6.1.0', 'SVN Foundation'), - ) + detect=all_of( + any_of( + startswith('.1.3.6.1.2.1.1.2.0', '.1.3.6.1.4.1.2620'), + all_of( + equals('.1.3.6.1.2.1.1.2.0', '.1.3.6.1.4.1.8072.3.2.10'), + equals('.1.3.6.1.4.1.2620.1.6.1.0', 'SVN Foundation'), + ) + ), + equals('.1.3.6.1.4.1.2620.1.1.21.0', 'Firewall'), ) ) diff --git a/checkpoint_fw_connections.mkp b/checkpoint_fw_connections.mkp index 191d07f6b3e7418642e38945bef0a91c3c399b0f..bacbe9fe31da4add1d2a3185d8eb0c73a6fadc27 100644 Binary files a/checkpoint_fw_connections.mkp and b/checkpoint_fw_connections.mkp differ diff --git a/packages/checkpoint_fw_connections b/packages/checkpoint_fw_connections index 435d04f69614b62cb2474323df5397b8bb48de9b..851c84c984b03e01a3e327e3e9ac72d889fd21c9 100644 --- a/packages/checkpoint_fw_connections +++ b/packages/checkpoint_fw_connections @@ -1,9 +1,28 @@ {'author': 'Th.L. (thl-cmk[at]outlook[dot]com)', 'description': 'Monitor Check Point Firewall connection statistics.\n' '\n' - 'Rewrite of the original check.\n' - 'Added perfdata for peak connections and TCP, UDP, ICMP, other ' - 'and total connection rate\n', + 'This plugin supersedes the "checkpoint_connections" plugin.\n' + '\n' + 'Service\n' + ' - Firewall connections\n' + '\n' + 'Metrics \n' + ' - TCP connections/s\n' + ' - UDP connections/s\n' + ' - ICMP connections/s\n' + ' - Other connections/s\n' + ' - Total connections/s\n' + ' - Connections rate/s\n' + ' - Current connections\n' + ' - Peak Connections\n' + ' - Current connections relative to table limit (if ' + 'available)\n' + '\n' + 'WATO\n' + ' - Upper/Lower levels for current connections (absolute)\n' + ' - Upper/Lower levels for current connections (relative to ' + 'connection table limit)\n' + ' - Admin connection table limit\n', 'download_url': 'https://thl-cmk.hopto.org', 'files': {'agent_based': ['checkpoint_fw_connections.py'], 'web': ['plugins/metrics/checkpoint_fw_connections.py', @@ -11,7 +30,7 @@ 'name': 'checkpoint_fw_connections', 'num_files': 3, 'title': 'Check Point Connections', - 'version': '20210824.v.0.0.3', + 'version': '20210825.v.0.0.3a', 'version.min_required': '2.0.0', 'version.packaged': '2021.07.14', 'version.usable_until': None} \ No newline at end of file